Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stdlib): wait for async translations #587

Merged
merged 2 commits into from
Nov 24, 2020
Merged

fix(stdlib): wait for async translations #587

merged 2 commits into from
Nov 24, 2020

Conversation

lkipke
Copy link
Collaborator

@lkipke lkipke commented Nov 24, 2020

Change summary

Apparently I forgot how async code works. This fixes how we load the translation files, so that we actually wait for them to load before executing.

@lkipke lkipke added bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior stdlib Affects the standard library included with this BrightScript implementation labels Nov 24, 2020
@lkipke lkipke self-assigned this Nov 24, 2020
sjbarag
sjbarag approved these changes Nov 24, 2020
View reviewed changes
Copy link
Owner

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whooooops. Thanks for catching that :)

src/stdlib/Localization.ts Outdated Show resolved Hide resolved
@lkipke lkipke merged commit 9cec4c2 into sjbarag:main Nov 24, 2020
@lkipke lkipke deleted the fix-async-translations branch November 24, 2020 19:25
@sjbarag sjbarag mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimnios72 alimnios72 alimnios72 approved these changes

@sjbarag sjbarag sjbarag approved these changes

@strattonbrazil strattonbrazil Awaiting requested review from strattonbrazil

@kirkyoder kirkyoder Awaiting requested review from kirkyoder

Assignees

@lkipke lkipke

Labels
bug Any difference between this BrightScript implementation and RBI, or otherwise unexpected behavior stdlib Affects the standard library included with this BrightScript implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkipke @sjbarag @alimnios72